Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop collection before updating in place #34

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

EricOuma
Copy link
Contributor

@EricOuma EricOuma commented Nov 7, 2023

Resolves #33

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1261b7a) 61.72% compared to head (7db1e54) 61.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   61.72%   61.58%   -0.14%     
==========================================
  Files          10       10              
  Lines         452      453       +1     
==========================================
  Hits          279      279              
- Misses        173      174       +1     
Files Coverage Δ
django_typesense/collections.py 55.67% <0.00%> (-0.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EricOuma EricOuma merged commit 378032d into main Nov 7, 2023
9 checks passed
@EricOuma EricOuma deleted the 33-fix-updating-of-collections-in-place branch November 12, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix updating of collections in place
2 participants